chore: fix package metadata and CFFI builder layout - #10
Merged
Conversation
- Rename ffi.py to _ffi_build.py and drop it from py_modules: it is a build-time script, but it was being installed into site-packages as a top-level module named 'ffi', colliding with any other package that ships one. The sdist still includes it via MANIFEST.in. - Drop the __name__ == '__cffi__' compile trick; the setuptools cffi_modules integration only needs the ffibuilder attribute and compiles the extension itself. - pyproject: remove setuptools from runtime dependencies (build-only), remove the invalid package-dir key under [build-system], drop the redundant wheel build requirement, and fill in description, SPDX license, keywords and classifiers for the PyPI page. - README: note that installing the sdist compiles the extension and needs liburing headers plus a C compiler. - Regenerate uv.lock (setuptools removed as a project dependency). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bright2227
marked this pull request as ready for review
July 28, 2026 15:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_ffi_build.pyand stop installing it as a top-level moduleWhy
The previous setup exposed the build-only
ffi.pyas an installable top-level module and did not accurately describe the package or its distribution contents.Impact
Installed wheels contain only the
uringlooppackage, while source distributions retain the CFFI build input needed to compile cleanly.Validation
uv run pytest -q— 17 passeduv run ruff check uringloop tests _ffi_build.pyuv lock --checktwine checkpassed for both artifactsgit diff --check main...HEAD