Change "Enter Local Time" to print timezone explicitly (if possible) instead of "Local"; add missing polar alignment test far from pole#525
Merged
Conversation
…bots#508 ADR-0018 + Positioning CONTEXT.md glossary: shared_state civil datetime is stored timezone-aware in UTC, normalised at the set_datetime() boundary, and read via utc_datetime()/local_datetime(); distinguish civil datetime (the astronomical epoch) from measurement epoch (time.time() fix-age). Captures the GPS LST->LKT rename and the no-naive-local-persisted-data finding.
…orce DTZ Add PiFinder/timez.py as the single sanctioned source of datetimes (utc_now / local_now / utc_from_timestamp / parse / naive / utc) and enable ruff's DTZ (flake8-datetimez) family repo-wide, exempting only timez.py. Every bare datetime.now() / datetime(...) / strptime() / fromtimestamp() now routes through timez, so 'local or UTC?' is explicit at the call site and a naive value cannot silently reach the astronomy/ephemeris path. Also fixes a latent relabel bug in the comets.py freshness check (a file mtime read naive-local and stamped UTC -> now the true UTC instant via timez.utc_from_timestamp). See ADR-0018.
alexis-cousein
force-pushed
the
fix_state_dt_tz
branch
from
99444b8 to
42674de
Compare
alexis-cousein
force-pushed
the
fix_state_dt_tz
branch
from
42674de to
965730e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent merge was, alas, missing two unpushed changes that were on my local machine. Self explanatory, we want to explicitly display "Enter Europe/Brussels Time" rather than "Enter Local Time" to confirm that the timezone is what the user expects in the time entry screen.
And another test for polar alignment was very near the pole, and as such may miss some Alt-Az decomposition errors that would have been more blatant with a mount axis pointing really far from the pole. I had a second test but it never got pushed to github when the tests were merged.