Skip to content

fix(anthropic): end the span when a streaming messages.create call fails #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexcastgonz (pcbeingused333) wants to merge 1 commit into from
Closed

fix(anthropic): end the span when a streaming messages.create call fails #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 75 additions & 0 deletions ...nthropic/cassettes/0.48.0/test_anthropic_sync_create_stream_logs_error_and_ends_span.yaml
View file
Open in desktop

@AbhiPrasad Abhijeet Prasad (AbhiPrasad) Oct 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these cassettes are not valid

    status:
      code: 401
      message: Unauthorized

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

75 changes: 75 additions & 0 deletions ...nthropic/cassettes/latest/test_anthropic_sync_create_stream_logs_error_and_ends_span.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions py/src/braintrust/integrations/anthropic/test_anthropic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1740,3 +1740,24 @@ def test_sync_batches_results_logs_error_on_failure(self, memory_logger):
span = spans[0]
assert span["span_attributes"]["name"] == "anthropic.messages.batches.results"
assert "results fetch failed" in span["error"]


@pytest.mark.vcr
def test_anthropic_sync_create_stream_logs_error_and_ends_span(memory_logger):
# A request that the API rejects (here: an invalid API key, a 401) must end the span with
# the error, as it does for the non-streaming call and for the async client.
assert not memory_logger.pop()

client = wrap_anthropic(anthropic.Anthropic(api_key="invalid-key-for-error-cassette"))
with pytest.raises(anthropic.AuthenticationError):
client.messages.create(
model=MODEL,
max_tokens=16,
messages=[{"role": "user", "content": "hi"}],
stream=True,
)

spans = memory_logger.pop()
assert len(spans) == 1
assert spans[0]["span_attributes"]["name"] == "anthropic.messages.stream"
assert spans[0]["error"]
7 changes: 6 additions & 1 deletion py/src/braintrust/integrations/anthropic/tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,12 @@ def create(self, *args, **kwargs):
def __trace_stream(self, stream_func, *args, **kwargs):
span = _start_span("anthropic.messages.stream", kwargs)
request_start_time = time.time()
s = stream_func(*args, **kwargs)
try:
s = stream_func(*args, **kwargs)
except Exception as e:
span.log(error=e)
span.end()
raise
return TracedMessageStreamManager(s, span, request_start_time)


Expand Down
Loading