Repository navigation
fix(ci): collect nox durations from JSON reports - #939
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intoOct 14, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/github-action-failure-819c51a3
branch
October 14, 2026 22:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weekly session-weight update failed because Nox logged
test_coreas successful "in a minute", while the timing collector only accepted numeric seconds. That silently dropped the measurement and caused the update step to reject the incomplete data.Read exact durations from Nox's JSON report, rounded to integer seconds, while preserving live output, successful-session filtering, and the Nox exit code. Add regression coverage for minute/hour and subsecond durations, skipped sessions, and failed runs.
Validation: regression tests failed before the fix and pass afterward; a real
test_corerun through the collector passed (1,072 passed, 106 skipped, 12 xfailed) and produced a timing artifact. Pre-commit and targeted Pylint checks with CI's--errors-onlysetting passed.Failing run: https://github.com/braintrustdata/braintrust-sdk-python/actions/runs/38213044375/job/114692644878