Repository navigation
fix(mistral): capture new request params and streamed logprobs - #926
Merged
Abhijeet Prasad (AbhiPrasad) merged 2 commits intoOct 13, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Abhijeet Prasad (AbhiPrasad)
force-pushed
the
abhi/mistral-request-params-9067952b
branch
from
October 13, 2026 15:35
1fe41f1 to
0047103
Compare
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/mistral-request-params-9067952b
branch
October 13, 2026 16:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mistral 3.2.0 exposes sampling and probability parameters that currently disappear from Braintrust span metadata. Capture all seven parameters for chat and agents calls, and retain completion and prompt probabilities when accumulating streamed choices.
Fixes #922.
Changes
logprobs,top_logprobs,prompt_logprobs,top_prompt_logprobs,min_tokens,repetition_penalty, andtop_kto both metadata allowlists.zai-glm-5-3, which accepts the new parameters; older SDK versions keep their existing model and recordings. Non-streaming chat and agents tests check both probability fields. Streaming checks completion probabilities because the hosted model rejects prompt probabilities with streaming.Validation
logprobs.latest)Run from
py/:mise exec -- nox -R -s 'test_mistral(latest)' 'test_mistral(2.10.1)' 'test_mistral(1.12.4)' -- --vcr-record=none.The cassette usage runner completed successfully across the entire matrix and reported no unused recordings. Pre-commit, stale cassette detection, lockfile validation, and
git diff --checkpass. Inspected the three new recordings: they contain only successful responses and filtered authorization headers.