Repository navigation
fix(pydantic-ai): capture conversation input on agent spans - #925
Merged
Abhijeet Prasad (AbhiPrasad) merged 2 commits intoOct 13, 2026
Merged
Conversation
Normalize Conversation messages and id into the existing message_history and conversation_id input fields so trace normalizers retain prior turns. Add version-gated VCR coverage for all five agent run methods and consolidate overlapping pydantic-ai tests and recordings. Fixes #923
Abhijeet Prasad (AbhiPrasad)
marked this pull request as ready for review
October 13, 2026 15:27
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Scope unexpected-keyword-arg suppression to the conversation tests, which require pydantic-ai >= 2.55.0. Python 3.10 lint uses an older compatible SDK whose agent run signatures do not accept conversation yet.
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/pydantic-conversation-vcr-f42f815a
branch
October 13, 2026 16:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent spans omitted prior history when callers used pydantic-ai's
conversation=argument. Capture its shaped messages asinput.message_historyand its ID asinput.conversation_id, so existing trace normalizers display the full conversation. Normalize after forwarded kwargs so sync and event-stream APIs cannot overwrite the ID with aNonedefault.Adds cassette-backed regressions for all five instrumented agent run methods, gated to pydantic-ai >= 2.55.0. Consolidates overlapping agent/settings tests, removes one redundant direct-request test and its cassettes, and shares completion/streaming recordings across the conversation cases.
Validation:
Fixes #923