Repository navigation
fix(temporal): distinguish cancellations from execution errors - #1059
Merged
Abhijeet Prasad (AbhiPrasad) merged 2 commits intoNov 3, 2026
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c0918e990
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Base automatically changed from
abhi/temporal-subagent-spans-2610819b
to
main
November 3, 2026 17:20
> 🤖 **This text was AI-generated.**
Stopping a chat through Temporal cancellation previously logged cancellation
exceptions as errors, while asyncio cancellations had no cancellation marker.
Use Temporal's cancellation classifier for workflow and activity spans,
including cancellations wrapped in activity or child workflow exceptions:
```python
# Before: cancellation could populate error or leave no marker.
# After:
span.log(metadata={"temporal.cancelled": True})
```
Preserve exception propagation and span cleanup. Ordinary failures continue
to populate error. Cover direct, activity, and child workflow cancellation
alongside an ordinary failure with real Temporal workflows.
Fixes: https://linear.app/braintrustdata/issue/SDK-782
> 🤖 **This text was AI-generated.** Cache eviction cancels workflow tasks internally. Extend the existing replay test to assert that a successful workflow has neither temporal.cancelled metadata nor an error. The replay span hook already suppresses these writes. The child cancellation test could inspect spans before the child finished cancelling. Wait for completion before checking the exported spans: ```text before: request child cancellation -> inspect spans after: request child cancellation -> await completion -> inspect spans ``` Refs: #1059 (comment) Refs: https://linear.app/braintrustdata/issue/SDK-782
Abhijeet Prasad (AbhiPrasad)
force-pushed
the
abhi/sdk-782-distinguish-temporal-workflow-cancellation-events-from-other
branch
from
November 3, 2026 17:20
1c0918e to
440f84e
Compare
Andrew Kent (realark)
approved these changes
Nov 3, 2026
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/sdk-782-distinguish-temporal-workflow-cancellation-events-from-other
branch
November 3, 2026 18:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopping a chat through Temporal cancellation previously logged cancellation exceptions as errors, while asyncio cancellations had no cancellation marker.
Use Temporal's cancellation classifier for workflow and activity spans, including cancellations wrapped in activity or child workflow exceptions:
Preserve exception propagation and span cleanup. Ordinary failures continue to populate error. Cover direct, activity, and child workflow cancellation alongside an ordinary failure with real Temporal workflows.
Fixes: https://linear.app/braintrustdata/issue/SDK-782