Repository navigation
fix(temporal): preserve trace context across continue-as-new - #1057
Merged
Abhijeet Prasad (AbhiPrasad) merged 2 commits intoNov 3, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Base automatically changed from
abhi/temporal-subagent-spans-2610819b
to
main
November 3, 2026 17:20
Abhijeet Prasad (AbhiPrasad)
force-pushed
the
abhi/braintrust-pr-1054-9edfc013
branch
from
November 3, 2026 17:21
d3cb476 to
4b4fbc5
Compare
Andrew Kent (realark)
approved these changes
Nov 3, 2026
> 🤖 **This text was AI-generated.**
BraintrustPlugin did not attach span context to continue-as-new commands.
Continued runs could lose the original trace or skip the span that requested
the continuation.
Propagate the current span through Temporal headers using the same helper
as activities and child workflows. Each run keeps its own workflow span
while remaining in the original trace:
```text
before: run 1 run 2 run 3
after: run 1
└─ run 2
└─ nested span
└─ run 3
```
Cover both transitions in one real Temporal workflow chain, with and
without a client parent and with cached and replayed workflow execution.
Span end-time handling remains outside this change.
Fixes https://linear.app/braintrustdata/issue/SDK-780
Abhijeet Prasad (AbhiPrasad)
force-pushed
the
abhi/braintrust-pr-1054-9edfc013
branch
from
November 3, 2026 18:20
4b4fbc5 to
71dd6bd
Compare
Abhijeet Prasad (AbhiPrasad)
enabled auto-merge (squash)
November 3, 2026 18:20
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/braintrust-pr-1054-9edfc013
branch
November 3, 2026 18:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BraintrustPlugin did not attach span context to continue-as-new commands. Continued runs could lose the original trace or skip the span that requested the continuation.
Propagate the current span through Temporal headers using the same helper as activities and child workflows. Each run keeps its own workflow span while remaining in the original trace:
Cover both transitions in one real Temporal workflow chain, with and without a client parent and with cached and replayed workflow execution. Span end-time handling remains outside this change.
Fixes https://linear.app/braintrustdata/issue/SDK-780