Repository navigation
fix(temporal): include activity retry attempts in metadata - #1056
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intoNov 3, 2026
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Base automatically changed from
abhi/temporal-subagent-spans-2610819b
to
main
November 3, 2026 17:20
> 🤖 **This text was AI-generated.** Activity retries produce separate spans, but their metadata does not show which attempt each span represents. Include Temporal's activity attempt number on every activity span, including local activities: ```text before: activity span metadata has no attempt number after: temporal.activity_attempt = 1, then 2 on retry ``` Extend the existing workflow tests to check attempt numbers. Combine the basic child-workflow checks into the delegation test and remove the unused parent workflow fixture. Fixes: https://linear.app/braintrustdata/issue/SDK-783
Abhijeet Prasad (AbhiPrasad)
force-pushed
the
abhi/sdk-783-include-temporal-activity-retry-attempt-numbers-in-metadata
branch
from
November 3, 2026 17:21
6a19ade to
91e7d1c
Compare
Andrew Kent (realark)
approved these changes
Nov 3, 2026
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/sdk-783-include-temporal-activity-retry-attempt-numbers-in-metadata
branch
November 3, 2026 18:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activity retries produce separate spans, but their metadata does not show which attempt each span represents. Include Temporal's activity attempt number on every activity span, including local activities:
Extend the existing workflow tests to check attempt numbers. Combine the basic child-workflow checks into the delegation test and remove the unused parent workflow fixture.
Fixes: https://linear.app/braintrustdata/issue/SDK-783