Repository navigation
chore(api): update pinned OpenAPI spec - #1039
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af16b84832
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
Upstream removed the Simulated users operations and schemas, so the stale generated_tags entry made regeneration fail. Remove the tag, regenerate the client and README, and drop the facade property, type re-exports, and test references. Also name OpenAPI update PR branches after the pinned upstream commit so each automated update gets its own branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4260043d7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| "Roles", | ||
| "ServiceTokens", | ||
| "Simulated users", | ||
| "SpanIframes", |
There was a problem hiding this comment.
After this selection drops Simulated users and the generated client removes that resource, openapi/README.md lines 22–30 still lists it among the reviewed generated tags. This leaves the code-generation guide's explicit inventory inconsistent with config.json, so maintainers consulting it will believe the removed resource is still generated; update that inventory alongside the selection.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in f822548: removed Simulated users from the reviewed tag inventory in openapi/README.md.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Automated update of the pinned Braintrust OpenAPI specification.
d9102b7592e8→3384e4be354eOperation changes
createSimulatedUser,deleteSimulatedUser,getSimulatedUser,listSimulatedUsers,patchSimulatedUserComponent schema changes
AppLimit,CreateSimulatedUser,PatchSimulatedUser,SimulatedUser,SimulatedUserVoiceConfigAutomated validation
The update workflow regenerates committed sources and public API reference sections, then runs:
make -C py test-api-codegenmake -C py test-corecd py && nox -s test_typesThis pull request is never auto-merged. Review the upstream and generated diffs, retry-policy classifications, public type changes, and any intentionally unsupported tags before merging.
Manual fixes
The automated run failed regeneration because
Simulated userswas removed upstream but still listed inendpoint_generator.generated_tags. Follow-up commits:Simulated usersfromgenerated_tagsinopenapi/config.jsonand regenerated the client andpy/src/braintrust/api/README.md(deletes_generated/simulated_users.pyand its models; dropsAppLimit).simulated_usersproperty inapi/client.py, theCreateSimulatedUser/ListSimulatedUsersResponse/PatchSimulatedUser/SimulatedUserre-exports inapi/types/__init__.py, and the matching test references.Breaking:
client.simulated_usersand the four types above are no longer available, matching the upstream removal.Workflow results
Original automated run:
failurefailuresuccesssuccessAfter manual fixes (run locally):
make -C py generate-api-clientsuccessmake -C py test-api-codegensuccess(66 passed)make -C py test-coresuccess(1122 passed)cd py && nox -s test_typessuccess(37 passed)make -C py lintsuccess🤖 Generated with Claude Code