Make coding-agent hook capture journal-only - #50
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95ed034d6c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| let p = parse!(FlushParams); | ||
| // Explicit flushes wait for the daemon-owned ingress queue. Hook | ||
| // capture never waits on this barrier. | ||
| daemon.settle_ingress().await; |
There was a problem hiding this comment.
do we need a timeout here?
3 participants
Summary
Verification
cargo test --manifest-path bt-daemon/Cargo.toml --all-featurescargo clippy --manifest-path bt-daemon/Cargo.toml --all-features --all-targets -- -D warningscargo fmt --manifest-path bt-daemon/Cargo.toml -- --checkmake buildmake testrun_commandtool trace produced the expected five-span tree in projectcoding-agentsflush_on_turn_endhook returned in 0.22s; regression test enforces the durable-journal boundary with a stalled sink