Separate translator checkpoints from finalization - #38
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c9c5482dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Stephen Belanger (Qard)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Andrew Kent (realark)
September 1, 2026 16:18
Abhijeet Prasad (AbhiPrasad)
approved these changes
Sep 1, 2026
Stephen Belanger (Qard)
deleted the
fix/translator-checkpoint-finalize
branch
September 1, 2026 16:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A delivery flush and a session shutdown are different lifecycle events. Previously both called the same translator flush method, so an ordinary delivery barrier could close the live session root, turn, and pending work. Later events then reused state that had already been finalized.
This PR gives that distinction one shared daemon contract:
This is the translator-lifecycle slice extracted from #26. It deliberately does not include source identity, managed-run, import, or distribution changes.
Current-main and overlap check
Rebuilt directly on current main at c29184b. The open PRs were reviewed before publishing: #28 concerns JavaScript span transforms, #33 removes MCP proxy packages, and #26 is the omnibus being replaced. None implements this lifecycle separation.
Validation
The four real-agent tests remain ignored because they require installed agent CLIs and credentials; all deterministic tests pass.