Conversation
Reverts the temporary revert commit f76013a, restoring the TailwindCSS v4 (CSS-first) migration originally merged via PR #470. The revert was a release-window hold so EditorInput 1.8.1 could ship on Tailwind v3; that release is out, so the v4 migration (v2.0.0) is back on staging. Conflict resolutions: version bumped to 2.0.0 in package.json, package-lock.json, version.json, and README install refs; changelog keeps the 1.8.1 entry with the 2.0.0 entry restored on top.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,12 +1,12 @@ | |||
| { | |||
| "name": "@bsf/force-ui", | |||
| "version": "1.8.1", | |||
There was a problem hiding this comment.
What: The version of the package has been bumped to 2.0.0, but there is no changelog entry or comment detailing breaking changes or necessary migration steps for users.
Why: Documentation is essential, especially when introducing breaking changes, to help users update their implementations without issues. Failing to document changes can lead to user confusion and potentially faulty implementations.
How: Add a clear section in the README or change log detailing what has changed in version 2.0.0, specifically highlighting any breaking changes and migration advice.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reverts the temporary revert commit
f76013ad, restoring the TailwindCSS v4 (CSS-first) migration originally merged via #470.Why
The migration was reverted on Aug 3 as a release-window hold so EditorInput
1.8.1could ship on Tailwind v3. That release is out, so the v4 migration comes back to staging, per the plan recorded in the revert commit message.Notes
2.0.0inpackage.json,package-lock.json,version.json, and README install refs.1.8.1entry with the restored2.0.0entry on top.tailwind.config.jsis deleted again (v4 is CSS-first; theme ships as@bsf/force-ui/theme.css).withTW()deprecated).