Repository navigation
Hypnotoad-like corner data for gridue converter - #154
Merged
Merged
Conversation
…com:boutproject/boutdata into Hypnotoad-like-corner-data-gridue-converter
wearysebas
approved these changes
Nov 16, 2026
wearysebas
left a comment
Contributor
There was a problem hiding this comment.
Looks good, I tested it against my UEDGE grids and got the same BOUT++ grids as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to add the
Rxy_*corners,Zxy_*cornersvariables to the gridue converter toolsrc/boutdata/gridue_to_bout_converter/gridue_to_bout.py.Changes to the README.md due to actions bot e9b8477.
Corners were identified through discussion with chat-based LLM, and using the comment
and assuming that upper corresponds to the bottom row (not a typo), lower to the top row (not a typo), left to the left column, right to the right column:
A suggestion for a test that verifies this identification would be useful.
As far as I understand, the output necessarily has zero guards in
y, hence, to enable other tools to read the netcdf file, I set the following variable.Note that some logic for removing guards in double null was being executed in single null cases cb3a81c.