Store all api callbacks even if they dont have a order (#1827)

* Store all api callbacks even if they dont have a order

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update src/shop/views.py

* Update src/shop/views.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Thomas Steen Rasmussen <tykling@bornhack.org>

Author: 3 people

src/shop/migrations/0088_alter_coinifyapicallback_order.py

@@ -0,0 +1,19 @@
+# Generated by Django 4.2.20 on 2025-04-21 11:24
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('shop', '0087_coinifyapipaymentintent'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='coinifyapicallback',
+            name='order',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.PROTECT, related_name='coinify_api_callbacks', to='shop.order'),
+        ),
+    ]

src/shop/models.py

@@ -1165,11 +1165,16 @@ class CoinifyAPICallback(
         "shop.Order",
         related_name="coinify_api_callbacks",
         on_delete=models.PROTECT,
+        blank=True,
+        null=True,
     )
     authenticated = models.BooleanField(default=False)
 
     def __str__(self):
-        return f"order #{self.order.id} callback at {self.created}"
+        if self.order:
+            return f"order #{self.order.id} callback at {self.created}"
+        else:
+            return f"other callback at {self.created}"
 
 
 class CoinifyAPIRequest(

src/shop/views.py

@@ -605,11 +605,8 @@ def post(self, request, *args, **kwargs):
 
         # save callback and parse json payload
         payload = json.loads(request.body.decode("utf-8"))
-        order = Order.objects.get(
-            coinify_api_payment_intents__coinify_id=payload["context"]["id"],
-        )
 
-        callbackobject = save_coinify_callback(request, order)
+        callbackobject = save_coinify_callback(request=request, order=None)
 
         # do we have a json body?
         if not callbackobject.payload:
@@ -624,15 +621,22 @@ def post(self, request, *args, **kwargs):
         callbackobject.valid = True
         callbackobject.save()
 
-        if (
-            callbackobject.payload["event"] == "payment-intent.completed"
-            or callbackobject.payload["event"] == "payment-intent.failed"
-        ):
+        if callbackobject.payload["event"] in [
+            "payment-intent.completed",
+            "payment-intent.failed",
+        ]:
+            order = Order.objects.get(
+                coinify_api_payment_intents__coinify_id=payload["context"]["id"],
+            )
             process_coinify_payment_intent_json(
                 intentjson=payload["context"],
                 order=order,
                 request=request,
             )
+            callbackobject.order = order
+            callbackobject.save()
+            return HttpResponse("OK")
+        if callbackobject.payload["event"] == "settlement.created":
             return HttpResponse("OK")
         else:
             logger.error(