Added tasker permission (#1823)

* Added tasker to permission set and secured the create/edit task views for the tasker permission

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Removed unused import

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix permission checking

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Remove unused mixin

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Thomas Steen Rasmussen <tykling@bornhack.org>

Author: 3 people

src/backoffice/templates/includes/permissions_explainer.html

@@ -13,6 +13,8 @@
     <dd>The team infopager permission grants access to manage infopage sections for the team. Codename <b>camps.{{ team.slug | default:"TEAM" }}_team_infopager</b>.</dd>
     <dt>pos</dt>
     <dd>The team pos permission grants access to submit point-of-sale reports on behalf of the team. Codename <b>camps.{{ team.slug | default:"TEAM" }}_team_pos</b>.</dd>
+    <dt>tasker</dt>
+    <dd>The team tasker permission grants access to manage tasks on behalf of the team. Codename <b>camps.{{ team.slug | default:"TEAM" }}_team_tasker</b>.</dd>
   </p>
   <p>
     <a href="{% url 'backoffice:index' camp_slug=camp.slug %}" class="btn btn-secondary"><i class="fas fa-undo"></i> Backoffice</a>

src/bornhack/settings.py

@@ -266,4 +266,5 @@
     "facilitator": "Team facilitator - facilities management",
     "infopager": "Team infopager - infopage management",
     "pos": "Team Pos - Point-of-sale report submission",
+    "tasker": "Team Tasker - task management",
 }

src/teams/models.py

@@ -328,6 +328,10 @@ def pos_permission_set(self):
     def infopager_permission_set(self):
         return f"camps.{self.slug}_team_infopager"
 
+    @property
+    def tasker_permission_set(self):
+        return f"camps.{self.slug}_team_tasker"
+
 
 class TeamMember(ExportModelOperationsMixin("team_member"), CampRelatedModel):
     user = models.ForeignKey(

src/teams/templates/team_tasks.html

@@ -16,7 +16,7 @@ <h4>Tasks</h4>
     <div class="card-body">
       <p>
         The {{ team.name }} Team is responsible for the following tasks.
-        {% if request.user in team.leads.all %}
+        {% if team.tasker_permission_set in perms %}
           <a href="{% url 'teams:task_create' camp_slug=camp.slug team_slug=team.slug %}" class="btn btn-primary"><i class="fas fa-plus"></i> Create Task</a>
         {% endif %}
       </p>
@@ -44,7 +44,7 @@ <h4>Tasks</h4>
                   <td>{{ task.completed }}</td>
                   <td>
                     <a href="{% url 'teams:task_detail' camp_slug=camp.slug team_slug=team.slug slug=task.slug %}" class="btn {% if task.completed %}btn-secondary{% else %}btn-primary{% endif %}" btn-sm"><i class="fas fa-search"></i> Details</a>
-                                                                                                                                                                                                                                    {% if request.user in team.leads.all %}
+                                                                                                                                                                                                                                    {% if team.tasker_permission_set in perms %}
                                                                                                                                                                                                                                       <a href="{% url 'teams:task_update' camp_slug=camp.slug team_slug=team.slug slug=task.slug %}" class="btn {% if task.completed %}btn-secondary{% else %}btn-primary{% endif %}" btn-sm"><i class="fas fa-edit"></i> Edit Task</a>
                     {% endif %}
                   </td>

src/teams/views/mixins.py

@@ -60,3 +60,10 @@ class TeamInfopagerPermissionMixin(RaisePermissionRequiredMixin):
 
     def get_permission_required(self):
         return [self.team.infopager_permission_set]
+
+
+class TeamTaskerPermissionMixin(RaisePermissionRequiredMixin):
+    """Permission mixin for views restricted to users with tasker permission for self.team"""
+
+    def get_permission_required(self):
+        return [self.team.tasker_permission_set]

src/teams/views/tasks.py

@@ -11,8 +11,8 @@
 from ..models import Team
 from ..models import TeamMember
 from ..models import TeamTask
-from .mixins import EnsureTeamLeadMixin
 from .mixins import TeamViewMixin
+from .mixins import TeamTaskerPermissionMixin
 from camps.mixins import CampViewMixin
 
 
@@ -74,7 +74,7 @@ def __init__(self, **kwargs):
 class TaskCreateView(
     LoginRequiredMixin,
     TeamViewMixin,
-    EnsureTeamLeadMixin,
+    TeamTaskerPermissionMixin,
     CreateView,
 ):
     model = TeamTask
@@ -103,7 +103,7 @@ def get_success_url(self):
 class TaskUpdateView(
     LoginRequiredMixin,
     TeamViewMixin,
-    EnsureTeamLeadMixin,
+    TeamTaskerPermissionMixin,
     UpdateView,
 ):
     model = TeamTask