Repository navigation
Fix release: download translations one at a time - #249
Merged
Merged
Conversation
pup i18n sends all 71 translation requests at once, and translate.wordpress.org now answers with 429 Too Many Requests, which failed the 0.10.0 release build three times. .github/scripts/i18n.ts reads the same .puprc i18n config, fetches one file at a time, and backs off on 429 and 5xx. Also strips trailing whitespace from zip.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.10.0 tag build failed at
pup i18nthree times in a row (run). Nothing was published: the WordPress.org SVN job never started.pup requests all 71 translation files (the locales at 30% or more) at the same moment, and translate.wordpress.org now answers that burst with
429 Too Many Requests. pup doesn't catch the error, so the step exits 255..github/scripts/i18n.tsreads the samei18nblock from.puprc. It fetches one file at a time with a short pause, backs off on 429 and 5xx (it honoursRetry-After), and fails if a file still can't be fetched. File names follow pup's default%textdomain%-%wp_locale%.%format%.zip.ymlruns it in place ofcomposer -- pup i18n. The.github/folder is in.distignore, so the script doesn't ship.zip.yml.Checked: ran the script locally. It saved all 71
.mofiles, the same names astags/0.9.2/languages/on SVN, and rode out four 429s along the way.After merging, the
0.10.0tag moves to the merge commit and is pushed again to re-run the release.