Repository navigation
snagflash: fix crash when flashing a bz2 image with a bmap file - #111
Merged
Merged
Conversation
The BZ2File class does not expose a "name" attribute before Python 3.13,
unlike GzipFile which always had one. This leads to the following crash
when flashing a bzip2-compressed image with a bmap file on Python < 3.13:
File "snagflash/bmaptools/BmapCopy.py", line 192, in __init__
self._image_path = image.name
AttributeError: 'BZ2File' object has no attribute 'name'
Fix it by falling back to a generic description when the file object
has no "name" attribute. _image_path is only used in log and error
messages, so this does not change any behavior for regular files.
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Assisted-by: opencode (GLM Flash)
Collaborator
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BZ2File class does not expose a "name" attribute before Python 3.13, unlike GzipFile which always had one. This leads to the following crash when flashing a bzip2-compressed image with a bmap file on Python < 3.13:
File "snagflash/bmaptools/BmapCopy.py", line 192, in init
self._image_path = image.name
AttributeError: 'BZ2File' object has no attribute 'name'
Fix it by falling back to a generic description when the file object has no "name" attribute. _image_path is only used in log and error messages, so this does not change any behavior for regular files.
Assisted-by: opencode (GLM Flash)