Repository navigation
added libusb-1.0.dll from pypi libusb. This is nedded to run on windows - #105
Merged
Merged
Conversation
rgantois
requested changes
Oct 2, 2026
rgantois
left a comment
Collaborator
There was a problem hiding this comment.
Hi Frederik, I've left a couple of comments below, overall the changes look good to me. I'll test this on my side once the comments are adressed.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the windows installer from release 3.0.0 running the
snagrecovercommand for usb-dfu devices results amissing backenderror. This is due to libusb-1.0.dll not being present in PATH and pyusb therefor not being able to use it. This MR solves this by using the libusb-1.0.dll distributed in the pypilibusblibrary, which has a very open zlib license. The dll file could also just be added to the repo, but i do not know how that works licensing wise. Having it locally in the repo might be preferable as the current solution in the snagboot.spec file is a little ugly.