Propagate agent/workflow-edits-allowed label from issues to PRs - #62
Conversation
When an issue has the agent/workflow-edits-allowed label, the drafter workflow now copies it to the pull request it creates. This allows subsequent fix iterations (via fix.md) to push changes to protected files without hitting the request_review gate. Fixes #61 Generated-by: AI
There was a problem hiding this comment.
Review Summary
This PR correctly fixes #61 by ensuring the agent/workflow-edits-allowed label is propagated from issues to pull requests.
What I Checked
✅ Correctness: The fix addresses the root cause identified in #61 — the drafter workflow now instructs the agent to check for the agent/workflow-edits-allowed label on the originating issue and propagate it to the PR at creation time.
✅ Implementation:
- Step 6 added: Check if originating issue has the label
- Step 7 (renumbered from 6): Include the label when creating the PR if present
- Cross-referenced with fix.md:89 which checks for this label on
github.event.pull_request.labels.*.name
✅ Lockfile Recompilation:
frontmatter_hashunchanged (correct — frontmatter not modified)body_hashchanged appropriately (correct — body content changed)
✅ Code Quality: Minimal, focused change with clear rationale documented in the step descriptions.
✅ Safety: Properly propagates an authorization label that must be manually applied to the issue beforehand — no new security risks introduced.
Recommendation
This PR is ready to merge. The change is minimal, correct, and follows repository conventions.
|
hmm and the agent would just put this in its safe outputs when creating the PR? I guess that works, and it's kind of hard to do anything better here without making it a skill with a script that does this stuff a bit more deterministically |
When an issue has the agent/workflow-edits-allowed label, the drafter workflow now copies it to the pull request it creates. This allows subsequent fix iterations (via fix.md) to push changes to protected files without hitting the request_review gate. Fixes #61 Generated-by: AI Co-authored-by: bootc-bot[bot] <225049296+bootc-bot[bot]@users.noreply.github.com>
Summary
Fixes #61
When an issue has the
agent/workflow-edits-allowedlabel, the drafter workflow now propagates it to the pull request it creates. This allows subsequent fix iterations (viafix.md) to push changes to protected files without hitting therequest_reviewgate.Changes
Modified
.github/workflows/drafter.mdto add two new steps in the agent's task instructions:agent/workflow-edits-allowedlabelWhy This Fixes #61
The issue occurred because:
agent/workflow-edits-allowedlabelagent/workflow-edits-allowedlabelWith this change, the label is propagated from issue → PR, allowing the fix workflow to complete successfully.
Validation
gh aw compileagent/workflow-edits-allowedlabel