fix: Rename agent/draft-working to agent/drafter-working - #60
fix: Rename agent/draft-working to agent/drafter-working#60bootc-bot[bot] wants to merge 2 commits into
Conversation
The working label for drafter.md was inconsistent with the naming pattern used by other workflows (review.md uses agent/review-working, fix.md uses agent/fix-working). This changes agent/draft-working to agent/drafter-working to match the established pattern. Updated: - .github/workflows/drafter.md: label name in add/remove steps - .github/workflows/install-labels.yml: label definition - scripts/install-labels.js: label definition - README.md: documentation references - .github/workflows/drafter.lock.yml: recompiled from source Assisted-by: AI
![bootc-bot[bot]](https://avatars.githubusercontent.com/u/202312630?s=60&v=4){kind=small}
There was a problem hiding this comment.
The rename from agent/draft-working to agent/drafter-working is correct and fixes the naming inconsistency with other workflows. However, the PR missed updating two references in scripts/README.md:
Missing updates:
scripts/README.md:19— In the description of working labels, still referencesagent/draft-workingscripts/README.md:69— In thegh label createcommand example, still usesagent/draft-working
What needs to change:
Update both occurrences in scripts/README.md from agent/draft-working to agent/drafter-working to match the changes already made in README.md, install-labels.yml, install-labels.js, and the workflow files.
All other changes look good — the workflow files, label definitions, and main README are correctly updated.
bootc-bot
Bot
removed
the
agent/fixme
cgwalters
added
agent/fixme
bootc-bot
Bot
removed
the
agent/fixme
The review identified two remaining references to the old agent/draft-working label in scripts/README.md that were missed in the initial rename. Updated both occurrences (line 19 and line 69) to use agent/drafter-working to match the changes already made in other files. Assisted-by: AI
|
Commit pushed:
|
There was a problem hiding this comment.
Review Complete
This PR correctly renames agent/draft-working to agent/drafter-working to align with the established agent/{workflow-name}-working naming pattern used by other workflows.
Verified
- ✅ Pattern consistency: Now matches
review.md→agent/review-workingandfix.md→agent/fix-working - ✅ Completeness: All 6 files updated consistently (workflows, labels, docs)
- ✅ No orphaned references: Confirmed via grep that no
draft-workinginstances remain - ✅ Proper compilation: Lockfile metadata hash updated (
3a0bbf28...→4fe3076d...) - ✅ Documentation: README.md and scripts/README.md updated to reflect new label name
- ✅ Label definitions: Both install-labels.yml and install-labels.js updated
Changes
All changes are mechanical renames with no logic modifications:
drafter.md: 4 label references updated (add/remove steps + comments)drafter.lock.yml: Compiled output reflects source changes- Label definitions updated in both installation paths
- Documentation consistently updated across all README files
No issues found. This is ready to merge.
|
Needs a rebase (the lockfile here is just a conflict fest, that's a general issue) |
cgwalters
added
agent/fixme
1 participant
Fixes #58
Summary
The working label for
drafter.mdwas inconsistent with the naming pattern used by other workflows:review.mdusesagent/review-workingfix.mdusesagent/fix-workingdrafter.mdwas usingagent/draft-working(incorrect)This PR renames
agent/draft-workingtoagent/drafter-workingto match the establishedagent/{workflow-name}-workingpattern.Changes
.github/workflows/drafter.mdto useagent/drafter-workingin add/remove label steps.github/workflows/install-labels.ymllabel definitionscripts/install-labels.jslabel definitionREADME.mddocumentation references.github/workflows/drafter.lock.ymlfrom sourceValidation
Compiled all workflow lockfiles successfully using
gh aw compile drafter review fix queue-triage ci-triage --approvewith no errors.