Repository navigation
feat: expand batch TLS probes for everyday CLI tools - #2
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
Unresolved bootstrap and cache-isolation issues, together with credential handling across thirteen external clients, require fixes and human validation.
2 open issues
What changed in this PR
Expands embarass batch with thirteen additional CLI and runtime probes, extending TLS trust checks to more everyday developer tools.
Changes:
- Adds cloud, package-manager, Kubernetes, and runtime probes with temporary configuration and cache isolation.
- Embeds a Node.js probe that explicitly establishes the local proxy tunnel.
- Adds discovery and isolation tests, opt-in installed-tool checks, and usage documentation.
| File | Description |
|---|---|
| README.md | Documents new probes, isolation measures, and runtime requirements. |
| pkg/batchtest/probes/node.cjs | Implements the Node.js proxy tunnel and TLS request. |
| pkg/batchtest/plan.go | Registers additional tools and prepares cloud configuration. |
| pkg/batchtest/plan_test.go | Tests cloud probe isolation and optional real-client TLS behavior. |
| pkg/batchtest/everyday.go | Defines runtime and package-manager probes and workspace files. |
| pkg/batchtest/everyday_test.go | Tests executable aliases, isolation settings, and workspace cleanup. |
Review effort: Balanced
| "NPM_CONFIG_FETCH_RETRIES": "0", | ||
| "NPM_CONFIG_UPDATE_NOTIFIER": "false", | ||
| "PNPM_HOME": filepath.Join(workspace, "pnpm-home"), | ||
| "XDG_CACHE_HOME": filepath.Join(workspace, "pnpm-xdg-cache"), |
| EnvironmentOverrides: map[string]string{ | ||
| "CARGO_HOME": filepath.Join(workspace, "cargo"), | ||
| "CARGO_REGISTRIES_CRATES_IO_PROTOCOL": "sparse", | ||
| "CARGO_NET_RETRY": "0", |
Include the omitted completion implementation and tests that caused CI compilation failures. Preserve Corepack's existing executable cache before isolating pnpm caches, and disable rustup auto-install so bootstrap traffic cannot be mistaken for Cargo's TLS decision. Validated with full tests, race tests, golangci-lint, and the installed-Corepack cache regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.