Repository navigation
fix: test every trust path by default - #1
Merged
fproulx-boostsecurity merged 1 commit intoOct 22, 2026
Merged
Conversation
The default tested only the Sectigo cross-signed path. Mozilla-derived trust stores trust AAA Certificate Services for e-mail only, so a client can reject that path while still accepting the direct emSign path, and emBarrass reported such a vulnerable client as protected or inconclusive. --chain now defaults to "all": emsign runs first, then sectigo. The result is vulnerable as soon as any path is accepted, rejected only if every path rejects, and otherwise inconclusive, naming the path its reason and child exit came from. No further path starts after cancellation. --timeout applies per path, each run is announced so consecutive child output stays separable, and batch logs the deciding path. --chain emsign|sectigo still runs the command once.
Contributor
|
Love it thanks for the contrib @mrene |
fproulx-boostsecurity
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default tested only the Sectigo cross-signed path. Mozilla-derived trust stores trust AAA Certificate Services for e-mail only, so a client can reject that path while still accepting the direct emSign path, and emBarrass reported such a vulnerable client as protected or inconclusive.
--chain now defaults to "all": emsign runs first, then sectigo. The result is vulnerable as soon as any path is accepted, rejected only if every path rejects, and otherwise inconclusive, naming the path its reason and child exit came from. No further path starts after cancellation. --timeout applies per path, each run is announced so consecutive child output stays separable, and batch logs the deciding path. --chain emsign|sectigo still runs the command once.