Skip to content

fix(prompts): preserve falsy autocomplete initial values - #618

Open
btea wants to merge 2 commits into
bombshell-dev:mainfrom
btea:fix/autocomplete-initial-selection
Open

btea wants to merge 2 commits into
bombshell-dev:mainfrom
btea:fix/autocomplete-initial-selection

Conversation

@btea

@btea btea commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

When the initial value of autocomplete is set to falsy, it doesn't take effect due to a logical issue in the condition.

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • I have added a changeset

AI-generated code disclosure

  • This PR includes AI-generated code

@changeset-bot

changeset-bot Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b9ca20f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clack/prompts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

commit: b9ca20f

@dreyfus92 dreyfus92 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small thing, could we drop "@clack/core": patch from the changeset? this only touches prompts, so it'd publish an empty core release. also there's a typo, "thefirst" should be "the first". otherwise lgtm.

@btea

btea commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for reviewing. It has been updated.

@dreyfus92 dreyfus92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @btea lgtm 😄, i'm gonna wait for a second look from @43081j 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants