Repository navigation
chore: update biome and config file - #602
Conversation
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
43081j
left a comment
There was a problem hiding this comment.
makes sense! will wait for @dreyfus92 to review too
dreyfus92
left a comment
There was a problem hiding this comment.
hey @mixto thanks for handling this. i left a couple of comments before this lands 🤘🏻
also i wanted to ask you @43081j, the other bombshell repos are already on @bomb.sh/tools with oxfmt/oxlint, and clack is the last one still on biome. is a bsh migration planned for clack? if so this is fine as-is for now, just want to make sure we're not investing in config we're about to drop.
|
True we may want to move to the bombshell config but that is a larger task I think. So if this is trivial, I'm happy for it to go in. Though if this results in too much discussion because of changes in config, I'd rather leave it for now. |
commit: |
What does this PR do?
Update
@biomejs/biometo its latest version and adapt the config file to the current configuration specified in the project. I have omitted configuration options that are already set by default and, consequently, options that are not necessary. Full explanation:Modified files:
.editorconfig: Since all the project files will use a tab width of 2 for now, there's no need to set the configuration in Biome; just use the editorconfig option directly..vscode: I've added anextensions.jsonfile to improve integration with VS Code extensions and their forks, such as Cursor.CONTRIBUTING.md: I've changed the required version of pnpm to match thepackageManagerfield in thepackage.jsonfile in the project root.Omited configurations:
formatter.enabledtrueformatter.formatWithErrorsfalseformatter.indentStyletab(.editorconfig)formatter.indentWidth2(.editorconfig)formatter.lineEndinglf(.editorconfig)formatter.attributePositionautoformatter.bracketSpacingtruelinter.enabledtruejavascript.formatter.jsxQuoteStyledoublejavascript.formatter.quotePropertiesasNeededjavascript.formatter.semicolonsalwaysjavascript.formatter.arrowParenthesesalwaysjavascript.formatter.bracketSameLinefalsejavascript.formatter.bracketSpacingtruejavascript.formatter.attributePositionautooverrides: Since there are no.tomlfiles and Biome does not yet support.ymlfiles, it is not necessary to include these files in the configuration. Biome will never modify them.Observations:
On GitHub, files indented with tabs appear to have a 4-space indent, while in the editor they show up as 2 spaces, as specified in the settings. Maybe I should just use spaces for everything?
Type of change
Checklist
pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure