Skip to content

chore: update biome and config file - #602

Merged
dreyfus92 merged 4 commits into
bombshell-dev:mainfrom
mixto:biome
Sep 11, 2026
Merged

dreyfus92 merged 4 commits into
bombshell-dev:mainfrom
mixto:biome

Conversation

@mixto

@mixto mixto commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Update @biomejs/biome to its latest version and adapt the config file to the current configuration specified in the project. I have omitted configuration options that are already set by default and, consequently, options that are not necessary. Full explanation:

Modified files:

  • .editorconfig: Since all the project files will use a tab width of 2 for now, there's no need to set the configuration in Biome; just use the editorconfig option directly.

  • .vscode: I've added an extensions.json file to improve integration with VS Code extensions and their forks, such as Cursor.

  • CONTRIBUTING.md: I've changed the required version of pnpm to match the packageManager field in the package.json file in the project root.

Omited configurations:

option default value
formatter.enabled true
formatter.formatWithErrors false
formatter.indentStyle tab (.editorconfig)
formatter.indentWidth 2 (.editorconfig)
formatter.lineEnding lf (.editorconfig)
formatter.attributePosition auto
formatter.bracketSpacing true
linter.enabled true
javascript.formatter.jsxQuoteStyle double
javascript.formatter.quoteProperties asNeeded
javascript.formatter.semicolons always
javascript.formatter.arrowParentheses always
javascript.formatter.bracketSameLine false
javascript.formatter.bracketSpacing true
javascript.formatter.attributePosition auto
  • overrides: Since there are no .toml files and Biome does not yet support .yml files, it is not necessary to include these files in the configuration. Biome will never modify them.

Observations:

On GitHub, files indented with tabs appear to have a 4-space indent, while in the editor they show up as 2 spaces, as specified in the settings. Maybe I should just use spaces for everything?

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • I have added a changeset

AI-generated code disclosure

  • This PR includes AI-generated code

@changeset-bot

changeset-bot Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c233ad8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security

socket-security Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​biomejs/​biome@​2.1.2 ⏵ 2.5.12100 +110010099 +1100

View full report

@mixto
mixto marked this pull request as ready for review September 10, 2026 12:37
Comment thread biome.json Outdated

@43081j 43081j left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense! will wait for @dreyfus92 to review too

@dreyfus92 dreyfus92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @mixto thanks for handling this. i left a couple of comments before this lands 🤘🏻

also i wanted to ask you @43081j, the other bombshell repos are already on @bomb.sh/tools with oxfmt/oxlint, and clack is the last one still on biome. is a bsh migration planned for clack? if so this is fine as-is for now, just want to make sure we're not investing in config we're about to drop.

Comment thread .changeset/afraid-animals-call.md Outdated
Comment thread biome.json Outdated
Comment thread .editorconfig
@43081j

43081j commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

True we may want to move to the bombshell config but that is a larger task I think. So if this is trivial, I'm happy for it to go in.

Though if this results in too much discussion because of changes in config, I'd rather leave it for now.

@pkg-pr-new

pkg-pr-new Bot commented Sep 11, 2026

Copy link
Copy Markdown

commit: c233ad8

@dreyfus92 dreyfus92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @mixto ✌🏻

@dreyfus92 dreyfus92 changed the title feat: update biomejs & adapt config file chore: update biome and config file Sep 11, 2026
@dreyfus92
dreyfus92 merged commit c681d2b into bombshell-dev:main Sep 11, 2026
9 checks passed
@mixto
mixto deleted the biome branch September 11, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants