Repository navigation
Fix/mcp session status codes - #216
Merged
Merged
Conversation
… requests GET /mcp without a session now returns 405 (no standalone SSE stream), and requests with an unknown or expired session return 404 with JSON-RPC code -32001, so clients re-initialize instead of retrying. The repeated 400s were tripping fail2ban. Extract createMcpHttpServer() so tests can exercise the real handler.
The transport map and sessionStore drifted apart: TTL expiry, the cleanup interval and per-key eviction removed store entries but left transports open forever, and requests never refreshed the TTL. Add SessionStore.onDelete() and route every removal through delete(). The server closes the matching transport from that listener, and looks up sessions via the store so each request refreshes the TTL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.