Add kernel-side element detection to ShowEDS#145
Merged
Conversation
Owner
|
seems like we have 2 PRs now, what should we do? |
Contributor
Author
Thanks @bobleesj, this one is ShowEDS element detection (independent of #142), I just updated it a bit so it would better integrate into ShowDiffraction. ShowEDS used to rank Auto-ID candidates in the browser without background subtraction and peak finding, now we move the detection into the kernel and also detect peaks better so it can be integrated reliably into other modules |
Owner
|
thanks! it would be nice if screenshots were attached so that we could reduce this roundtrip |
Owner
|
i will mergei it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.