Allow overriding testdb Postgres connection via env vars, skip podman…#4
Merged
Conversation
… when DB already reachable PGDEVKIT_TESTDB_HOST/PORT/USER/PASSWORD now override the container defaults, and ensure_container() first probes the target with a short (3s) timeout before ever shelling out to podman — plus the existing PGDEVKIT_SKIP_CONTAINER escape hatch now lives in one place. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KZ9GdQRrr1e1EHcZHb7496
…vars The finally block reloaded pgdevkit.testdb.constants while the overridden PGDEVKIT_TESTDB_* env vars were still set (monkeypatch only restores them after the test function returns), so the module stayed loaded with otherhost/otheruser/otherpass for the rest of the test session — breaking the real podman/postgres integration tests that ran afterward in CI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KZ9GdQRrr1e1EHcZHb7496
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… when DB already reachable
PGDEVKIT_TESTDB_HOST/PORT/USER/PASSWORD now override the container defaults, and ensure_container() first probes the target with a short (3s) timeout before ever shelling out to podman — plus the existing PGDEVKIT_SKIP_CONTAINER escape hatch now lives in one place.
Claude-Session: https://claude.ai/code/session_01KZ9GdQRrr1e1EHcZHb7496