Drop sqlglot[c] compiled extra, depend on plain sqlglot#10
Merged
Conversation
The compiled sqlglotc package swaps sqlglot's generator/dialect modules process-wide on import, not opt-in per usage. Any downstream app that subclasses sqlglot's Generator/Dialect classes (a common pattern) breaks with "interpreted classes cannot inherit from compiled" the moment it depends on pgdevkit, regardless of whether it uses pgdevkit's Postgres features at all. pgdevkit only ever does plain `import sqlglot` - no code here needs the compiled speedup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiled sqlglotc package swaps sqlglot's generator/dialect modules process-wide on import, not opt-in per usage. Any downstream app that subclasses sqlglot's Generator/Dialect classes (a common pattern) breaks with "interpreted classes cannot inherit from compiled" the moment it depends on pgdevkit, regardless of whether it uses pgdevkit's Postgres features at all. pgdevkit only ever does plain
import sqlglot- no code here needs the compiled speedup.