Skip to content

frontend: kraken: KrakenManager: Move from 2min to 30min to upload tar file#3946

Merged
patrickelectric merged 1 commit into
bluerobotics:masterfrom
patrickelectric:improve-timeout
Jun 10, 2026
Merged

frontend: kraken: KrakenManager: Move from 2min to 30min to upload tar file#3946
patrickelectric merged 1 commit into
bluerobotics:masterfrom
patrickelectric:improve-timeout

Conversation

@patrickelectric

@patrickelectric patrickelectric commented Jun 10, 2026

Copy link
Copy Markdown
Member

Summary by Sourcery

Enhancements:

  • Extend Kraken extension tar file upload timeout from 2 minutes to 30 minutes to accommodate larger or slower uploads.

…r file

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider extracting the 30-minute timeout value into a named constant or shared configuration so it’s easier to adjust and keep consistent with other upload-related timeouts in the future.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider extracting the 30-minute timeout value into a named constant or shared configuration so it’s easier to adjust and keep consistent with other upload-related timeouts in the future.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions

Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: LGTM :shipit:

Bumps the uploadExtensionTarFile axios timeout in core/frontend/src/components/kraken/KrakenManager.ts from 120 000 ms (2 min) to 30 * 60 * 1000 ms (30 min) so that larger or slower Kraken extension tar uploads don't time out. Expressing the value as 30 * 60 * 1000 is also a nice readability win over the raw millisecond literal.

No further comments, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

@patrickelectric patrickelectric merged commit 2a6209a into bluerobotics:master Jun 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants