Skip to content

Changed ES5 code to ES6 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SunJieMing wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed ES5 code to ES6 #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
var logger = function() {
var message = 'hi';
const logger = () => {
const message = 'hi';
console.log(message);

@SunJieMing SunJieMing Aug 7, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your indentation is off. Make it 2 spaces instead of 5

};

var looper = function() {
var message = 'I love JS!';
for (var i = 0; i < 10; i++) {
const looper = () => {
const message = 'I love JS!';
for (let i = 0; i < 10; i++) {
console.log(message);
}
};

var greet = function(name) {
var greeting = 'Hello ' + name + '!';
const greet = (name) => {
const greeting = `Hello ${name}!`;
console.log(greeting);
};

var yourName = 'put your name in here';
const yourName = 'Ben';

logger();
looper();
Expand Down