Repository navigation
feat(init): default spectre_version to the binary's SPECTRE version - #58
Merged
Merged
Conversation
A template that builds SPECTRE into an image needs a version to pin, and the one the CLI is built from is the one its user is running. Passing it by hand was an easy way to get a mismatch. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A template that builds SPECTRE into an image, like ruby2jsc's mirror, needs a SPECTRE version to pin. The CLI's own version is the natural default, and passing it by hand invites a mismatch.
spectre initnow sets thespectre_versionvariable from the build info, unless--var spectre_version=...is passed. It uses the version of the block/spectre module, whether that is the main module (the OSS binary) or a dependency (a custom binary such as squareup's). A release gives its tag, such asv1.1.0. An untagged build gives its commit. A localreplaceor a(devel)build gives nothing, so the template asks for the flag.🤖 Generated with Claude Code