Complete curtailment topology targets plan - #983
Conversation
There was a problem hiding this comment.
Pull request overview
Archives and marks as completed the accepted implementation plan for curtailment topology targets (building, rack, group), aligning the plan lifecycle with the already-merged end-to-end coverage and enabling the tracking issue to close on merge.
Changes:
- Updates the plan frontmatter
statusfromimplementingtocompleted.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
🔐 Codex Security Review
Review SummaryOverall Risk: NONE FindingsNo security, correctness, or reliability findings. NotesThe authoritative diff only archives a completed planning document and updates its frontmatter status. It changes no executable code, configuration, dependencies, generated artifacts, or protocol definitions. Generated by Codex Security Review | |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29c9669c1a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| title: "Curtailment building, rack, and group targets" | ||
| date: 2026-08-11 | ||
| status: implementing | ||
| status: completed |
There was a problem hiding this comment.
Keep the plan active until topology events are manageable
For any active building-, rack-, or group-scoped curtailment, mapCurtailmentEventScopeToFormValues still returns undefined (client/src/protoFleet/api/curtailmentMappers.ts:135-136), leaving activeEventFormValues null and causing the Manage action to return without opening the editor (CurtailmentManagementPanel.tsx:800-803). This contradicts the plan's acceptance requirement that active events use the canonical scope conversion, so marking the plan completed and closing #909 hides a concrete unfinished user flow; keep it implementing until these scopes hydrate like the other terminal scopes.
AGENTS.md reference: AGENTS.md:L150-L157
Useful? React with 👍 / 👎.
Reviewable diff: +1/-1 across 1 file (excludes generated, test, and story files).
Summary
This PR records completion of the building, rack, and group curtailment targeting work after the final end-to-end coverage merged in PR #981. It archives the accepted implementation plan and closes the tracking issue when merged.
How it works
The plan frontmatter moves from
implementingtocompleted, and the document moves from the active plans directory intodocs/plans/archive/. The closing reference below lets GitHub close issue #909 when this lifecycle update merges.Diagrams
Areas of the code involved
docs/plans/archive/2026-08-11-curtailment-building-rack-and-group-targets-plan.mdKey technical decisions & trade-offs
Testing & validation
git diff --checkstatus: completedand the active-plan path no longer exists.Closes #909