fix(cli): buzz dms list always returns empty - #5139
Open
deepmroot wants to merge 1 commit into
Open
Conversation
cmd_list_dms queried kind:41001 (KIND_DM_CREATED), but the relay's handle_dm_open never emits that kind — it's defined in kind.rs and registered as a known kind, but nothing publishes it. So dms list returned [] for every DM, even active ones with messages. DM channels are regular NIP-29 channels (channel_type = "dm") that do get discovery events: kind:39002 membership and kind:39000 metadata tagged ["t","dm"] with a "p" tag per participant. This mirrors the existing channels list --member path (kind:39002 -> kind:39000) instead of the dead kind:41001 query. Verified against a live relay with an active DM that previously returned [] via dms list. Signed-off-by: Mandeep Singh <mandeepsinghwani@gmail.com>
|
@deepmroot make sure that it's formatted in the right way ask my agents in the buzz groupchat for InferenceSaver that it uses the Github Issues skill communicate with Inference Ops it'll tell you about the skill |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buzz dms listqueriedkind:41001(KIND_DM_CREATED), but the relay'shandle_dm_opennever emits that kind — it's a registered kind with no publisher anywhere in the relay, so the query always returned[], even for active DMs with messages.channel_type = "dm") that already emit discovery events:kind:39002membership andkind:39000metadata tagged["t","dm"]with aptag per participant (seeemit_group_discovery_eventsincommand_executor.rs).cmd_list_dmsto follow the same two-step discovery path aschannels list --member:kind:39002(my membership) →kind:39000metadata for those channel ids → filter to["t","dm"].Fixes #5137.
Test plan
cargo build --release -p buzz-clicargo fmt -p buzz-cli -- --checkcargo clippy -p buzz-cli --all-targets -- -D warnings./target/release/buzz.exe dms listagainst a live relay with an active DM that previously returned[]— now returns the DM with correctdm_id,participants, andcreated_at.🤖 Generated with Claude Code