feat(desktop): add team sharing to community catalog

[wpfleger96]

Stack: #5112 → this PR

Stacks on the team catalog backend PR (#5112). Contains all desktop/src/**, desktop/tests/**, and desktop/playwright.config.ts changes — 32 files, +4,322/−693 lines.

TS parse layer

teamCatalogRelay.ts decodes kind 30178 projection events into TeamCatalogEntry records. catalogRelay.ts generalizes the persona catalog relay into a shared base that both persona and team catalog hooks extend, eliminating the per-kind duplication in the previous persona-only implementation.

Hooks

useTeamCatalogRelay.ts subscribes to the team catalog kind, applies freshness ordering, and exposes the decoded entries. useAgentsDataRefresh.ts gains team catalog invalidation alongside the existing persona refresh path.

CommunityCatalogDialog

Single unified surface replacing the two former separate dialogs. Agents and Teams appear as labeled sections; the selection helper (communityCatalogSelection.ts) handles preferred-loading, vanished-item repair (explicit selection cleared when the encoded key leaves live data), and cross-section auto-init. All selection transitions are covered by 15 deterministic unit tests in communityCatalogSelection.test.mjs.

TeamShareDialog

Publishes and unshares catalog entries via the backend set_team_shared Tauri command (both share and unshare transitions call set_team_shared).

e2e + screenshots

team-catalog.spec.ts covers the full browse + adopt flow. team-catalog-screenshots.spec.ts produces the 8-image pixel-regression set (comment 5208042093).

Deletion

PersonaCatalogDialog.tsx is removed; persona browsing now lives inside the unified CommunityCatalogDialog.

[wpfleger96]

Catalog browse (collapsed members)

Browsing a community team — description and member list with model summary. Members show a chevron indicating they're expandable.

Member expanded

Reviewer row expanded — metadata card (Type / Preferred model / Preferred runtime / Preferred provider) + agent instruction rendered via Markdown.

Team instructions

Team-level instructions section rendered below the description, using the same Markdown treatment as the persona catalog.

Added state

After adding — action reads "Added to my teams" and is disabled.

Empty catalog

Share dialog — not shared

Share dialog — published

[wpfleger96]

Team catalog — browse

Community catalog list showing shared team cards with member counts and publisher attribution.

Team catalog — member expanded

Detail pane with a member row expanded: AgentDefinitionMetadata (model/runtime/provider) and member system prompt.

Team catalog — team instructions

Detail pane with all members collapsed, showing the team-level instructions section below the description.

Team catalog — added state

Detail pane after adding a team; action reads "Added to my teams".

Team catalog — empty state

Empty catalog when no teams have been shared to the community.

Team share dialog — not shared

Share settings panel with the catalog-share Switch unchecked (not shared).

Team share dialog — shared/published

Share dialog with the catalog-share Switch checked; team queued for publication.

[wesbillman]

Reviewing on Wes's behalf. Requesting changes for two security blockers in the catalog review surface:

1. Verify relay events before they can affect paging, coordinate selection, attribution, or displayed content. fetchCatalogEvents currently inserts every raw RelayEvent returned by the socket into byId and derives oldestCreatedAt from it; sharedCatalogHeads then trusts the raw id, pubkey, created_at, tags, and content. RelayClient.fetchEvents is only a transport fetch and does not verify signatures. A forged/unsigned 30178 event can therefore appear under another publisher, claim or retract their coordinate ahead of a valid signed head, and control the pagination cursor. The backend re-fetch and verification correctly prevents adoption, but it does not protect browsing, publisher attribution, remote image loads, or denial/shadowing of legitimate entries. Please verify ID + signature on a fresh wire-shaped object before adding an event to the paging map or deriving a cursor/head from it, and add regressions for a forged newer head, forged author/content, malformed signature, and an invalid event attempting to control until. The equivalent hardening and tests already exist in PR #4220 for kind 30175; this shared helper should preserve that invariant for both 30175 and 30178 rather than regress it.

2. Render executable team/member instructions byte-for-byte, not as Markdown, and reject non-reviewable controls at the adoption boundary. TeamCatalogDialog.tsx passes both team.instructions and member.systemPrompt through the chat Markdown renderer. Markdown can conceal spoiler bodies, link destinations, and image sources, so the instructions reviewed in the dialog can differ materially from the plaintext later executed by the adopted agents. The current team catalog validators only enforce schema/size bounds, so bidi/default-ignorable controls can also make reviewed text differ from execution. Please use the literal instruction-review component/invariant from PR #4220 and apply its executable-text validation to team instructions and every member prompt before publication/adoption. Add coverage proving Markdown syntax stays literal, hidden controls fail closed, and accepted bytes are preserved exactly through adoption.

The feature has unusually substantial coverage otherwise: this head adds/changes 62 test/spec/fixture files, including the Rust adoption/pending/sharing/reconcile suites, TS relay/parser tests, and Playwright catalog/screenshot specs. CI is green at e64aa20ff81e236ca068aab3b9ad93142fb839e3, but the existing fixtures use placeholder sig: "sig" values and therefore do not exercise the first trust boundary.

[wpfleger96]

Community Catalog — browse (teams section)

Team list with name, member count, description, and "Add team" footer.

Community Catalog — member expanded

Per-member row expanded showing Type, Preferred model/runtime/provider, and agent instruction.

Community Catalog — team instructions

Team instructions section collapsed above member rows.

Community Catalog — already added

Footer button reads "Added to my teams" (disabled) after the team is adopted.

Community Catalog — empty state

Both agents and teams empty: "Nothing shared yet" placeholder.

Share dialog — not yet shared

Share dialog before enabling catalog access.

Share dialog — published

Share dialog with catalog toggle on and published toast.

[wpfleger96]

Community Catalog — browse (teams section)

Team list with name, member count, description, and "Add team" footer.

Community Catalog — member expanded

Per-member row expanded showing Type, Preferred model/runtime/provider, and agent instruction.

Community Catalog — team instructions

Team instructions section collapsed above member rows.

Community Catalog — already added

Footer button reads "Added to my teams" (disabled) after the team is adopted.

Community Catalog — empty state

Both agents and teams empty: "Nothing shared yet" placeholder.

Community Catalog — both sections

Agents and Teams section headers both visible with one shared entry each.

Share dialog — not yet shared

Share dialog before enabling catalog access.

Share dialog — published

Share dialog with catalog toggle on and published toast.