Repository navigation
feat(todos): filter, edit and delete todos - #1559
Closed
johnmatthewtennant wants to merge 2 commits into
Closed
johnmatthewtennant wants to merge 2 commits into
johnmatthewtennant wants to merge 2 commits into
Conversation
Each todo row gains a More menu with Edit and Delete. Edit swaps the label for an inline field: Enter or leaving the field saves, and Escape cancels. Only the label's source changes, so the checkbox, assignee and subtasks stay as they were. Delete removes the todo's lines with its subtasks, and asks first when it has subtasks. Status and assignee filters sit above the list. A parent stays visible when any of its subtasks match, so a match keeps its context. Co-authored-by: Martha <73923046810b68ae182000e74ef7c444383a907df20f81f2ba1008870a6f45a1@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: John Tennant <jtennant@block.xyz>
A Chromium and WebKit journey opens Edit from the row menu, which returns focus as it closes, and checks that the inline field keeps focus and saves. It then filters to Done and deletes from there. The empty-filter note is plain text, so the panel keeps one save status. Co-authored-by: Martha <73923046810b68ae182000e74ef7c444383a907df20f81f2ba1008870a6f45a1@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: John Tennant <jtennant@block.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1483.
Context
Todos in a channel Canvas could be added, checked, given a status and assigned, but not renamed or removed, and a long list had no way to narrow it. Fixing a typo or dropping a stale task meant editing the Canvas Markdown by hand.
Changes
· Assignee: Sam) is refused.Testing
model.test.ts: label edits keep status, assignee, subtasks and CRLF; empty, multiline, stale and structure-changing edits are refused; deletes remove exactly the todo and its subtasks.TodosPanel.test.tsx: edit from the menu (Escape cancels, Enter saves once, focus returns to the checkbox), delete with and without the subtask confirmation, and status/assignee filters keeping parents.todos.spec.mjs: in Chromium, the inline field keeps focus after the menu closes, and edit, filter and delete save the expected Canvas.🤖 Generated with Claude Code