Repository navigation
fix(messages): stop the channel timeline jumping back when agents or search read old messages - #1256
Merged
Merged
Conversation
…y out of its timeline Agents, search and previews read channel messages through the session, and the store merged every result into the open channel window. An old message from such a read landed above the loaded history with a gap below it. Each older page then filled that gap in the middle of the list, so the timeline neither anchored the reader nor told the rows from new arrivals: the reader jumped back and the Jump to latest button counted the page as new messages. A window now shows rows only from its loaded history and newer. Rows from before it wait for the page that reaches them. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <loganj@squareup.com>
Main fails typecheck since #1250 made effort required and #1185 added this fixture without it. Same one-line fix as in #1257 and #1260. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <loganj@squareup.com>
loganj
marked this pull request as ready for review
October 16, 2026 17:01
kalvinnchau
reviewed
Oct 16, 2026
…ast them The history floor read the window cursor, but a reconnect catch-up moves that cursor to the new head. When more than one page arrived during the outage, every row the reader had loaded fell below the floor and vanished. The window now keeps its own floor: the oldest point a page read reached. It only falls while the window lives and resets when the window's rows are cleared. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <loganj@squareup.com>
kalvinnchau
approved these changes
Oct 16, 2026
johnmatthewtennant
added a commit
that referenced
this pull request
Oct 16, 2026
…lation * origin/main: (139 commits) feat(agents): let plugins read each agent's sessions (#1111) chore(deps): upgrade vitest to 5.0.4 (#1272) feat(plugins): reload folder plugins from the CLI (#1265) add channel shared sessions discovery and retrieval (#1254) polish Solo activity layout and fold previous steps (#1257) fix(agents): clarify model defaults and provider actions (#1177) fix(messages): stop the channel timeline jumping back when agents or search read old messages (#1256) Add Close other tabs to the tab menu (#1127) chore(deps): upgrade virtua to 0.53.5 and port its scroll patch (#1269) Auto-tag Berd drafts with a chosen default agent (#1139) test: delete styling, markup and call-count trivia tests (#1255) fix(hooks): preserve recovery ownership on lefthook 2.2.2 (#1174) fix(deps): upgrade vulnerable tls and editor dependencies (#1267) chore(terminal): upgrade xterm with compatible navigation (#1268) feat(goose): show goose and provider marks on agent cards (#1260) fix(agents): show native agent pictures in the Solo agent picker (#1258) test(agents): fix main typecheck — add effort to Goose fixture (#1262) fix(messages): reject unclaimed file and link drops app-wide (#1075) feat(channels): create and read system channels (#965) Refine message layout and bubble reading widths (#1218) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
Details
Also in this PR
One line in
src/features/agents/launch-boundary.test.tsadds the missingeffortfield to the Goose fixture. Main fails typecheck without it since #1250 and #1185 landed together. #1257 and #1260 carry the same line, so the hunks merge cleanly in any order.