Skip to content

Add support for Browser in /e/ OS #6885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
althafvly wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −0
Open

Add support for Browser in /e/ OS #6885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions app/src/main/assets/fido2_privileged_google.json
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@lucasmz-dev lucasmz-dev May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the wrong file

Copy link
Copy Markdown
Contributor

@lucasmz-dev lucasmz-dev May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also make sure to put the data in alphabetical order, so foundation.e.browser would be one of the first on the list, after com. maybe

Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,22 @@
}
]
}
},
{
"type": "android",
"info": {
"package_name": "foundation.e.browser",
"signatures": [
{
"build": "release",
"cert_fingerprint_sha256": "FD:8B:1E:55:5D:40:2A:47:ED:3B:72:F3:C4:73:82:5E:A7:D2:FD:9E:C7:AD:36:60:7C:2C:E0:04:C2:10:08:06"
},
{
"build": "release",
"cert_fingerprint_sha256": "FE:36:B0:0A:C2:F0:5F:2E:29:50:33:C6:DE:C2:4E:A4:52:0E:D4:39:24:59:39:74:8D:8F:03:A5:E0:C1:90:A9"
Comment on lines +885 to +890
Copy link
Copy Markdown
Contributor

@lucasmz-dev lucasmz-dev May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are there two keys

Copy link
Copy Markdown
Author

@althafvly althafvly May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasmz-dev /e/OS has both official and community builds, and they use different signing keys for browser.

Copy link
Copy Markdown
Contributor

@lucasmz-dev lucasmz-dev May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the same for all community builds...? Because I could see this being resigned by every maintainer and it would be crazy to add every unofficial build here

Copy link
Copy Markdown
Contributor

@lucasmz-dev lucasmz-dev May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kind of weird that it is different at all to me. There's like prebuilts too

Copy link
Copy Markdown
Author

@althafvly althafvly May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasmz-dev Both official and community builds are made by /e/OS team. So it's same for all.

Copy link
Copy Markdown
Author

@althafvly althafvly May 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Community builds are not officially tested by the team for each devices. That's why it's seperated. Unofficial builds type is usually called 'test'. Which is not included in this list as it uses public keys.

}
]
}
}
]
}
1 change: 1 addition & 0 deletions app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/accessibility/util/BrowserUtil.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ private val ACCESSIBILITY_SUPPORTED_BROWSERS = listOf(
Browser(packageName = "com.yjllqint.kito", urlFieldId = "search_box"),
Browser(packageName = "com.yujian.ResideMenuDemo", urlFieldId = "search_box"),
Browser(packageName = "com.z28j.feel", urlFieldId = "g2"),
Browser(packageName = "foundation.e.browser", urlFieldId = "url_bar"),
Browser(packageName = "idm.internet.download.manager", urlFieldId = "search"),
Browser(packageName = "idm.internet.download.manager.adm.lite", urlFieldId = "search"),
Browser(packageName = "idm.internet.download.manager.plus", urlFieldId = "search"),
Expand Down
3 changes: 3 additions & 0 deletions app/src/main/res/xml/autofill_service_configuration.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,9 @@
<compatibility-package
android:name="com.z28j.feel"
android:maxLongVersionCode="10000000000" />
<compatibility-package
android:name="foundation.e.browser"
android:maxLongVersionCode="10000000000"/>
<compatibility-package
android:name="idm.internet.download.manager"
android:maxLongVersionCode="10000000000" />
Expand Down
Loading