Repository navigation
RAR5: avoid copying decoder state before independent streams - #99
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streaming a non-solid RAR5 member used to copy the previous dictionary and Huffman tables, then immediately reset them. Prepare an independent decoder instead, for both ordinary and split members. Keep the previous decoder until output and integrity checks succeed, preserving rollback and cancellation.
Readers with a workspace limit now prepare without allocating or charging a duplicate history; some operations that previously exceeded the limit can therefore succeed. Unlimited readers reserve an empty buffer capped by the previous capacity and the next member's output size, avoiding repeated growth without copying discarded bytes. Solid members retain their existing checkpoint behavior.
The implementation adds no public API or persistent decoder fields. Smaller dictionaries still use the existing streaming capacity adjustment; this change does not claim to remove that temporary reservation.
Validation:
A temporary same-binary codec probe compared old clone/reset with the final preparation code, alternating order and taking seven-sample medians. Across five runs, 16 independent 2 MiB members took 20–35% less time; with a 16 MiB predecessor, they took 45–52% less time. These are forced-streaming microbenchmarks, not end-to-end or default-settings performance claims. The probe was removed from the branch.