Repository navigation
Bulk-copy long RAR 2.0 matches - #101
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RAR 2.0 decoded every match one byte at a time, including long repetitions. Bulk-copy matches longer than 64 bytes when no workspace quota is active, extending overlapping patterns in successively larger runs. Keep the original scalar loop for short matches and quota-limited readers so their growth order and allocation-failure prefixes stay unchanged.
Preserve zero-distance normalization, whole-match zero filling before the window, pending matches across member boundaries, cloning, and trimmed solid history. Add comparisons against the original byte loop, including every allocation refusal and workspace limits, plus an encoded streaming/solid regression test.
Synthetic public-decoder measurements on two 256 KiB repetitive fixtures show roughly 6× and 9× faster decoding. Short-match-heavy and literal-only controls stay within a few percent of baseline in repeated measurements, with occasional noisy outliers. These are codec measurements, not general archive-extraction speedups; quota-limited readers retain the scalar path.
Validation:
claude -pplan and final reviews: approved, no blocking findings.