Repository navigation
Reuse legacy streaming output buffers - #100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RAR 1.3/1.5 reader allocated a new output buffer for every roughly 64 KiB streaming chunk. Keep one buffer local to the member and clear it after each successful sink write, reusing its capacity for subsequent chunks.
Matches can cross a chunk boundary and grow that buffer. Unlimited readers retain the grown capacity. Bounded readers reuse only an exact capacity match and release the preceding buffer before allocating a differently sized one, preserving workspace requirements for overshoot and smaller final chunks.
Validation:
A temporary same-binary probe measured 23 → 8 allocation attempts for a 1 MiB literal-only fixture, including packed-input buffering and excluding decoder construction. The bounded match-heavy fixture remains at 32 attempts, since overshoot requires replacement to preserve the existing quota behavior. Timing differences were small (roughly 0–3%); this is an allocation reduction, not a demonstrated throughput improvement. The temporary probe was removed from the branch.