Conversation
`DescriptorXKey::matches()` ignores the final derivation step for wildcard descriptors, so the xprv signer must validate its hardenedness separately before signing. Add regression tests for both hardened and unhardened wildcard derivation paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #563
Description
SignerWrapper<DescriptorXKey<Xpriv>>::sign_inputusesDescriptorXKey::matches()to determine whether a PSBT key originmatches the signer. Since
matches()ignores the final derivation step for wildcard descriptors, a hardened child could be accepted for an unhardened wildcard, and vice versa.Notes to the reviewers
DescriptorXKey::matches()intentionally ignores the wildcard's final path step, so the additional check is required to validate the wildcard-specific derivation constraint.Added regression tests covering both hardened and unhardened wildcard descriptors and their valid and invalid derivation paths.
Changelog notice
Before submitting