fix(ci): pin nightly toolchain for rustfmt - #537
Open
Arowolokehinde wants to merge 1 commit into
Open
Arowolokehinde wants to merge 1 commit into
Arowolokehinde wants to merge 1 commit into
Conversation
The CI fmt job ran cargo fmt on the stable toolchain resolved from rust-toolchain.toml, so the nightly-only options in rustfmt.toml (wrap_comments, comment_width, format_code_in_doc_comments) were silently ignored and never enforced. PRs could pass CI with formatting that just p would reject locally. Point the fmt job at a pinned nightly (nightly-2026-08-01) with the rustfmt component, and pin the same version in the justfile recipes so CI and local just runs produce identical formatting output. Fixes bitcoindevkit#535
Arowolokehinde
requested review from
ValuedMammal and
oleonardolima
as code owners
August 21, 2026 19:56
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #537 +/- ##
=======================================
Coverage 81.91% 81.91%
=======================================
Files 25 25
Lines 6535 6535
Branches 302 302
=======================================
Hits 5353 5353
Misses 1075 1075
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #535
Description
The CI fmt job ran cargo fmt on the stable toolchain resolved from rust-toolchain.toml, so the nightly-only options in rustfmt.toml (wrap_comments, comment_width, format_code_in_doc_comments) were silently ignored and never enforced. PRs could pass CI with formatting that
just pwould reject locally.Point the fmt job at a pinned nightly (nightly-2026-08-01) with the rustfmt component, and pin the same version in the justfile recipes so CI and local just runs produce identical formatting output.
Before submitting