Add user-facing events for applying updates after syncing

[tnull]

Describe the enhancement
When syncing, Wallet::apply_update returns Result<(), CannotConnectError> which doesn't give any information if/how all of the changes have been applied. It would be great to return a list of human readable events that reflect how the Wallet funds/status changed (e.g., with Inbound/Outbound variants).

Use case
Notifying the user about relevant on-chain events (e.g., "payment received"/"payment sent").

[notmandatory]

This is a good idea, but it needs more discussion and won't make it into the 1.0 milestone, moving to 1.1 for now.

I think it can be done by implementing some some conversion function CombinedChangeSet -> Vec<ChangeEvent> or something like that.

[notmandatory]

Sorry need to move this to 1.2 milestone as it still needs some design discussion.

[notmandatory]

@tnull are you still waiting for this or did you find a workaround using the change sets?

[tnull]

@tnull are you still waiting for this or did you find a workaround using the change sets?

We found a temporary workaround, which however requires us to iterate over all transactions known to the wallet on block connection, which isn't great. We also have no way to detect/handle reorgs this way, which is why we can only show transactions that have 6 confirmations or more. So yes, we're still waiting for a proper solution here.

[notmandatory]

Thanks for the feedback, moving this to the 2.1 milestone since we don't have a solution ready yet and 2.0 is due June 4.

[reez]

Just making some notes because we touched on this in the BDK calls this week.

1. We found a temporary workaround, which however requires us to iterate over all transactions known to the wallet on block connection

I believe this is found here https://github.com/lightningdevkit/ldk-node/pull/432/files#diff-18f5545e0b6d6f7d1d8ef9f744c9d6d1458baaffc419e69f826626c00dddc260R146

2. Open Issue in ldk-node to Expose on-chain transactions in events

3. When syncing, Wallet::apply_update returns Result<(), CannotConnectError> which doesn't give any information if/how all of the changes have been applied. It would be great to return a list of human readable events that reflect how the Wallet funds/status changed (e.g., with Inbound/Outbound variants).

Discussed exposing/returning this once IntentTracker merged