Bump library version + add changelog - #1112
Conversation
e78e6e7 to
04b9f40
Compare
| @@ -6,6 +6,56 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
|
|
|||
| ## [Unreleased](https://github.com/bitcoindevkit/bdk-ffi/compare/v3.0.0...HEAD) | |||
There was a problem hiding this comment.
Should this get changed to [Unreleased](https://github.com/bitcoindevkit/bdk-ffi/compare/v3.1.0...HEAD) ?
|
|
||
| ### Added | ||
|
|
||
| - Add `timeout` and `retry` argument on Electrum client builder [#1010] |
There was a problem hiding this comment.
We can remove this, nothing is wrong with the automated changelog, but the background for this is I asked to squeeze it into the 3.0.0 last minute #1010 (comment) and then it sort of overlapped a bit with the general addition of the automated changelog label stuff
There was a problem hiding this comment.
Ah yes I see. Cool!
04b9f40 to
7abca27
Compare
|
I'll wait and merge #1113 first, then rebase this branch onto master and merge then. |
7abca27 to
fc3c812
Compare
Cool, just ACK'd 1113 |
fc3c812 to
3e18225
Compare
|
@reez would you mind taking another look at this one? That'll set me up for cutting and pushing the tag. |
| - Add public descriptor conversion [#1054] | ||
| - Expose extract_tx_with_fee_rate_limit and extract_tx_unchecked_fee_rate on Psbt [#1056] | ||
|
|
||
| ### Fixed |
There was a problem hiding this comment.
There was a problem hiding this comment.
Will reply on the main thread!
ACK with this comment: For #1015 and #1030 it looks like they were generated by the changelog automation I think but you removed them so I’m assuming you did that for a specific reason so up to you if you want to add them back in or not? |
|
Sorry guys I removed those from the auto-generated notes because they were not quite changelog worthy at first glance (the auto-generation only grabs the PR title and puts it in the category defined by the label).
Note that we could also decide that important library version updates should come into the |
Sounds good, got my ACK so feel free to merge whenever you're ready |
3e18225 to
1490eea
Compare
1490eea to
5fa4898
Compare
This PR bumps the libraries to their release versions and adds the changelog entry for 3.1