Skip to content

fix(wallet): avoid deadlocks in custom persister callbacks - #1091

Draft
reez wants to merge 1 commit into
bitcoindevkit:masterfrom
reez:dead
Draft

reez wants to merge 1 commit into
bitcoindevkit:masterfrom
reez:dead

Conversation

@reez

@reez reez commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Description

Aims to prevent deadlocks when custom persistence callbacks re enter a wallet by invoking foreign code without wallet or persister locks held (trys to preserve staged changes and reject nested persistence safely).

Notes to the reviewers

Documentation

Changelog

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • I've added exactly one changelog:* label
  • I've linked the relevant upstream docs or specs above

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@thunderbiscuit

Copy link
Copy Markdown
Member

I added this one to the 3.2.0 milestone, but do let me know if I got it wrong and it's actually breaking, in which case I'll bump it to the 4.0.0 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants