DRAFT fix(descriptor): reject hardened public derivation paths

[reez]

Description

Prevents Descriptor::derive_address from panicking on hardened public-key derivation paths or hardened wildcards. These cases now return the existing HardenedDerivationXpub error.

Notes to the reviewers

So kinda 2 things to do/watch:

• Miniscript release: rust-miniscript#913 is merged on master but still needs a release-12.x backport and patch release? Once released we can update bdk-ffi’s lockfile to resolve the fixed version. (A new bdk_wallet release is not required for a compatible 12.x patch necessarily?) Keep the local guard until then.
• Descriptor ID: bdk_chain::DescriptorExt::descriptor_id still unwraps at_derivation_index(0), so these descriptors remain panicable there even after Miniscript returns an error. I might need to follow up upstream there. And changing bdk-ffi’s existing infallible signature would be breaking.

Documentation

• bdk_wallet
• bitcoin
• uniffi
• Other:

Changelog

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing
• I've added exactly one changelog:* label
• I've linked the relevant upstream docs or specs above

New Features:

• I've added tests for the new feature
• I've added docs for the new feature

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[ItoroD]

LGTM
Are we tracking the rust-miniscript patch ?

ACK 03a71ea

[reez]

LGTM Are we tracking the rust-miniscript patch ?

ACK 03a71ea

do you mean an open issue like #1082 or something else?

[ItoroD]

LGTM Are we tracking the rust-miniscript patch ?
ACK 03a71ea

do you mean an open issue like #1082 or something else?

Yes! Perfect