Skip to content

feat: add public descriptor conversion - #1054

Merged
reez merged 2 commits into
bitcoindevkit:masterfrom
reez:follow-up
Jul 30, 2026
Merged

reez merged 2 commits into
bitcoindevkit:masterfrom
reez:follow-up

Conversation

@reez

@reez reez commented Jul 30, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Follow up to #1043

Notes to the reviewers

Documentation

Changelog

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • I've added exactly one changelog:* label
  • I've linked the relevant upstream docs or specs above

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@thunderbiscuit thunderbiscuit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5a8af3f.

@reez
reez marked this pull request as ready for review July 30, 2026 19:53
@reez

reez commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator Author

added a commit updating the tests too for this.

will squash and merge when ci passes again

@reez
reez merged commit 41ccbc0 into bitcoindevkit:master Jul 30, 2026
8 checks passed
@reez
reez deleted the follow-up branch July 30, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants