test: add CreateParams / LoadParams wallet constructor smoke coverage - #136
Open
Johnosezele wants to merge 2 commits into
Open
Johnosezele wants to merge 2 commits into
Johnosezele wants to merge 2 commits into
Conversation
Johnosezele
force-pushed
the
test/create-load-params-smoke
branch
from
September 16, 2026 20:30
f33af76 to
702b439
Compare
j-kon
reviewed
Sep 17, 2026
j-kon
left a comment
Contributor
There was a problem hiding this comment.
The new smoke tests look great!
Since both tests already call revealNextAddress(keychain: KeychainKind.external_) before persisting to SQLite, we could also verify that the persisted derivation state survived the reload by asserting the reloaded wallet's derivation index:
expect(
reopenedWallet.derivationIndex(keychain: KeychainKind.external_),
equals(0),
);Tested locally against Wallet.loadWithParams and Wallet.loadSingleWithParams and it passes cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateParams/LoadParamswallet constructorsWallet.createWithParamsandWallet.createSingleWithParamsWallet.loadWithParamsandWallet.loadSingleWithParamsCloses #135
Why
Existing tests cover
Wallet(...),Wallet.createSingle, andWallet.load. They do not call the*WithParamsconstructors added inbdk-ffiv3.1.0. This only proves those Dart binding paths are callable and that the returned wallets lift into usable objects.