Add OneKey Pro to wallet list#4697
Conversation
Adds OneKey Pro to the hardware wallet list. Also updates the OneKey Classic 1S entry: description rewritten for clarity and "view website" link changed to the brand homepage.
|
Thanks for all the updates and the new submission! The most significant issue to be addressed from #4439 was:
Has that been addressed? |
|
@crwatkins Apologies for the slow reply. On the omission first: we read the closed-source MCU module question as being on a separate community / policy track (your Feb email mentioned working on a precedent for it), not as a per-PR item. That was the wrong call. I'll update the PR description shortly to make our position explicit. The binary in question is
The full wrapper is in |
Adds OneKey Pro to the hardware wallet list, completing the OneKey listing effort started in #4439 and continued in #4655.
Context:
Hardware features: open source firmware (https://github.com/OneKeyHQ/firmware-pro), four EAL 6+ certified secure elements, color touchscreen, fingerprint unlock, and air-gapped signing via QR codes (fresh address support landed in firmware v4.20.0 and OneKey App v6.2.0).
Reproducible builds verified by Wallet Scrutiny.
Transparency rating: Basic, consistent with Classic 1S, since the secure element firmware is vendor-supplied and not open source.
Closed-source fingerprint module (Pro-only):
The Pro firmware includes
libFpalgorithm.a, the sensor vendor's matching algorithm. The Classic 1S has no fingerprint sensor and is unaffected. The binary is vendor IP and is not available for open-sourcing on their end.Three properties characterize the binary's role in the device:
secboolmatch result (0x5a5a5a5afor true, any other value for false; resists single-bit-flip fault injection), plus template bytes during enrollment. Hardware drivers, image acquisition, and template storage are open source.Verifiable from open code: the full wrapper is in
core/embed/fp_sensor_wrapper/; the API surface is declared infpalgorithm_interface.h;nmon the.aconfirms exports.Also updating the Classic 1S entry: